Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27398 )
Change subject: usb: Match device by VID/PID without path/addr if it is unique
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This looks a bit dangerous. Because then the behavior of your program with the same config
changes based on the amount of devices you have connected on your system. Not sure
it's a good idea?
If only the VID/PID is needed in that case I'd expect that to come from config
explicitly (the user only specifies that one, and leave the path empty strlen()=0.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27398
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588
Gerrit-Change-Number: 27398
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 16:50:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment