Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email )
Change subject: s1gw_metrics: add histograms for gen_sctp:send delay
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I'm not sure it makes sense to have this kind of metric in regular use of the
software, only for really specific adhoc debugging.
In any case, this commit is missing rationale on why is it interesting to have this kind
of metric and what it exactly tries to measure.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7633a6e6182bda3fca4e7562e2b780b2b9f9708f
Gerrit-Change-Number: 39666
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Mar 2025 18:24:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No