Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 )

Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ......................................................................

Patch Set 1:

(3 comments)

File include/osmocom/gprs/llc/llc.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-39): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/463ef40d_f375ef55 PS1, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */ 'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'?

File src/llc/llc_pdu.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-39): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/3cb32e07_fd1188e4 PS1, Line 277: #define check_len(len, text) \ Macros with flow control statements should be avoided

File tests/llc_pdu_codec/pdu_codec_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-39): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/d82258a0_8c32cbc7 PS1, Line 31: static const char *testData[] = { static const char * array should probably be static const char * const