Attention is currently required from: neels, osmith.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35207?usp=email )

Change subject: util: add osmo_strbuf macros to manipulate the strbuf tail ......................................................................

Patch Set 1:

(1 comment)

File include/osmocom/core/utils.h:

https://gerrit.osmocom.org/c/libosmocore/+/35207/comment/69a340eb_7ca1d74b PS1, Line 329: } while (0)

yeah, it's becoming a habit. it is a form of inlining code but .. […]

inline functions have various advantages, starting from better syntax highlighting in the editor/IDE, higher chances that automatic tools might understand what's going on, and last but not least you also have your own scope for variables, ability to use recursive calls, ...