Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/31056
)
Change subject: gsm_r: EF_Predefined: Decode first record different from others
......................................................................
Patch Set 2:
(5 comments)
File pySim/gsm_r.py:
https://gerrit.osmocom.org/c/pysim/+/31056/comment/cb605dbb_1c7d5ed6
PS2, Line 252: EF_Predefined
self
https://gerrit.osmocom.org/c/pysim/+/31056/comment/e388e3ba_367cee2c
PS2, Line 254: EF_Predefined
self
https://gerrit.osmocom.org/c/pysim/+/31056/comment/1404d823_06fcb869
PS2, Line 257: r = None
this line can be safely removed
https://gerrit.osmocom.org/c/pysim/+/31056/comment/412ad605_4decbc94
PS2, Line 259: EF_Predefined
self
https://gerrit.osmocom.org/c/pysim/+/31056/comment/429c68e4_2da49f0b
PS2, Line 261: EF_Predefined
self
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/31056
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0
Gerrit-Change-Number: 31056
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 26 Jan 2023 14:55:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment