Attention is currently required from: laforge.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 )

Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:

oh, i see. so your unique_ids_test is a binary you build locally in this respository here. […]

No:

We are in libosmo-pfcp.git here, unique_ids_test lives in osmo-upf.git.

This here *installs* libosmo-pfcp.so, with pkgconfig info.

Then osmo-upf.git builds unique_ids_test, uses the installed libosmo-pfcp.so, which via installed pkgconfig is supposed to pull in libosmogsm.so. It works for libosmo-gtlv.so but not for libosmogsm.so.

So I am trying to find out why. This here is one attempt that somehow fixed things for me locally, but it might only have been confusing side effects from rebuilding.

If we get Requires.private to work then ok, if not then I really don't care enough to grind my soul over this, just to have a lib in Requires.private instead of in Requires. I'm sure we hardly ever cared about this before.

Maybe we can first put it in Requires, then if the build works go back to Requires.private and see if that still works, just to not stall the osmo-upf patches any longer?