Attention is currently required from: fixeria, jolly.

laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )

Change subject: After writing VTY config, run sync() in a different thread ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:

Not saying there can't be a better way, though ;) […]

I am quite sure the reason is "because it was easy to do". We don't care about whatever operations happen on the old file. We really only care that the newly written file has been written. So IMHO what is needed is fsync() on the [new] file itself, as well as fsync to the directory cotnaining the file. The "link" call (working with path names) might need to change to "linkat" (work with directory file descriptors)?