Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email )
Change subject: 5gc: Implement PDU Session Release procedure
......................................................................
Patch Set 2:
(2 comments)
File 5gc/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779/comment/cae18e38_2f58…
:
PS2, Line 407: bit2oct(nas_cause
Can you pass `cmd. […]
I could, but I want to
store it as nas_cause since it's a way to specify I'm "decoding" the
octetstring container.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779/comment/90278cd3_a0ce…
:
PS2, Line 418: li_resp := { it_resp };
I think you can do `li_resp[i] := it_resp`
unconditionally here. […]
I think it's fine here since it's a growing list
of items. The other way feels like filling some position for a size which was not
specified.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If79cb0c97008e7a9885bb548a3d2e67e41ba170f
Gerrit-Change-Number: 40779
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Jul 2025 10:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>