Attention is currently required from: clufn, laforge. pespin has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email ) Change subject: Add required conversions for IPv6 and IPv4v6 support ...................................................................... Patch Set 5: (2 comments) File src/conv.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/26ce07a3_6955… : PS5, Line 72: add_prefix(<<A:8, B:8, C:8, D:8, E:8, F:8, G:8, H:8, I:8, J:8, K:8, L:8, M:8, N:8, O:8, P:8>>) -> Then please submit this function when it is needed, not here 😊 https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/4f4518ab_60f5… : PS5, Line 136: ipv6 = remove_prefix(Addr)}; can you point to the related spec, or open a ticket in redmine with a pcap file or similar? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08 Gerrit-Change-Number: 40255 Gerrit-PatchSet: 5 Gerrit-Owner: clufn &lt;callumfarrbennett(a)yahoo.com&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: clufn &lt;callumfarrbennett(a)yahoo.com&gt; Gerrit-Comment-Date: Thu, 08 May 2025 09:04:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: clufn &lt;callumfarrbennett(a)yahoo.com&gt;