laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35820?usp=email ) Change subject: pylint: transport/calypso.py ...................................................................... pylint: transport/calypso.py pySim/transport/calypso.py:27:0: W0401: Wildcard import pySim.exceptions (wildcard-import) pySim/transport/calypso.py:61:23: W0622: Redefining built-in 'type' (redefined-builtin) pySim/transport/calypso.py:62:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) pySim/transport/calypso.py:73:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) pySim/transport/calypso.py:27:0: W0614: Unused import(s) NoCardError and SwMatchError from wildcard import of pySim.exceptions (unused-wildcard-import) Change-Id: I6b10d5f3370c00b07288300b537c6f0e17c84a87 --- M pySim/transport/calypso.py 1 file changed, 20 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/20/35820/1 diff --git a/pySim/transport/calypso.py b/pySim/transport/calypso.py index 7544d2e..6252137 100644 --- a/pySim/transport/calypso.py +++ b/pySim/transport/calypso.py @@ -24,7 +24,7 @@ from typing import Optional from pySim.transport import LinkBase -from pySim.exceptions import * +from pySim.exceptions import ReaderError, ProtocolError from pySim.utils import h2b, b2h, Hexstr, ResTuple @@ -58,9 +58,9 @@ L1CTL_RES_T_FULL = 0x01 L1CTL_RES_T_SCHED = 0x02 - def __init__(self, type=L1CTL_RES_T_FULL): - super(L1CTLMessageReset, self).__init__(self.L1CTL_RESET_REQ) - self.data += struct.pack("Bxxx", type) + def __init__(self, ttype=L1CTL_RES_T_FULL): + super().__init__(self.L1CTL_RESET_REQ) + self.data += struct.pack("Bxxx", ttype) class L1CTLMessageSIM(L1CTLMessage): @@ -70,7 +70,7 @@ L1CTL_SIM_CONF = 0x17 def __init__(self, pdu): - super(L1CTLMessageSIM, self).__init__(self.L1CTL_SIM_REQ) + super().__init__(self.L1CTL_SIM_REQ) self.data += pdu -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6b10d5f3370c00b07288300b537c6f0e17c84a87 Gerrit-Change-Number: 35820 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange