laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28561 )
Change subject: bankd: log BankID:SlotNr in every log line ......................................................................
bankd: log BankID:SlotNr in every log line
It's relatively inconvenient having to mentally map the slot-number to a thread-id on every (re)connect to correlate the logs.
The logs should contain the Bank/Slot number they relate to.
Closes: OS#5611 Change-Id: I84879609781a301338dacde7ff495632e3af08b9 --- M src/bankd/bankd.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved
diff --git a/src/bankd/bankd.h b/src/bankd/bankd.h index c007802..9bf9bc9 100644 --- a/src/bankd/bankd.h +++ b/src/bankd/bankd.h @@ -20,7 +20,7 @@ extern struct value_string worker_state_names[];
#define LOGW(w, fmt, args...) \ - LOGP(DBANKDW, LOGL_INFO, "[%03u %s] " fmt, (w)->num, get_value_string(worker_state_names, (w)->state), \ + LOGP(DBANKDW, LOGL_INFO, "[%03u B%u:%u %s] " fmt, (w)->num, (w)->slot.bank_id, (w)->slot.slot_nr, get_value_string(worker_state_names, (w)->state), \ ## args)
struct bankd;