osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29295 )
Change subject: jobs/gerrit-lint: hardcode shell command ......................................................................
jobs/gerrit-lint: hardcode shell command
Don't allow overriding cmd per repository anymore. This was used in the gerrit-osmo-ci-lint job to run the linter from the checked out osmo-ci.git repository (the one with the untrusted code submitted to gerrit).
This would become problematic with a future patch that will attach the ssh agent to the lint jobs (so jenkins can leave review comments over at gerrit).
Change-Id: Iad23da08898205fafd1ae36256c8f7b6d7506d40 --- M jobs/gerrit-lint.yml 1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/95/29295/1
diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index 9a1c1c5..f1fa389 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -5,7 +5,6 @@ name: gerrit-lint # following default values can be overridden by each repo disabled: false - cmd: '~/osmo-ci/lint/lint_diff.sh HEAD~1' gerrit_url: 'ssh://jenkins@gerrit.osmocom.org:29418' repos_url: '{gerrit_url}/{repos}' gerrit_project: '{repos}' @@ -34,10 +33,7 @@ - osmo-hnodeb - osmo-hnbgw - osmo-upf - - - osmo-ci: - # Run the lint script from the checked out branch - cmd: 'lint/lint_diff.sh HEAD~1' + - osmo-ci
- osmo_dia2gsup: repos_url: '{gerrit_url}/erlang/{repos}' @@ -149,7 +145,7 @@ server-name: gerrit.osmocom.org
builders: - - shell: '{obj:cmd}' + - shell: '~/osmo-ci/lint/lint_diff.sh HEAD~1'
wrappers: - ansicolor:
-
osmith