Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email )
Change subject: always use specific PDR ids for access and core
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
this looks like a completely cosmetic change? so it's not about explicit/implicit, but just using an enum value instead of magic numbers? If thats' the case, the commit message is a bit misleading, IMHO. [cosmetic] could also be added.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic343494001c70a84f3402ce5749d08e729551b26
Gerrit-Change-Number: 37756
Gerrit-PatchSet: 1
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Mon, 05 Aug 2024 12:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes