Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31004 ) Change subject: cards: also program EF.AD under ADF.USIM ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I expect the split was introduced in sysmoISIM-SJA2v2 (September 2021) when according to the changelog in the sysmoUSIM/ISIM user manual we have the item "EF.AD: set the bit that allows powering down the card during eDRX cycles". Splitting a previously linked file is always needed when the specs start to diverge, for example by introducing new bits in UICC/USIM which are not specified in classic DF_GSM File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/31004/comment/366ffadb_a733def8 PS1, Line 1587: pleaes don't mix tab and space indentation. We've switched to the (more pythonic) space-only indenting in pySim quite some time ago. Mixing both will render different formatting depending on how wide a tab is rendered (in python sometimes 4 spaces rather than 8). Python also often warns or errs about mixed tab/space indent for that reason -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic9dd4acc8d9a72acbb7376ddf3e2128125d4a8f5 Gerrit-Change-Number: 31004 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 06:54:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment