Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37499?usp=email ) Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+ ...................................................................... Patch Set 4: (4 comments) File pySim/esim/__init__.py: https://gerrit.osmocom.org/c/pysim/+/37499/comment/f286c822_7f0588ae PS3, Line 7: pmo4operation I just played a bit with the idea, but decided against it. First of all, I want lowercase string names as we use lowercase strings everywhere in our json (and all enum.Enum seems to use uppercase). Second, I'm not entirely sure how I can implement the bitstring-compatibility to it, as enum.Enum and derived classes seems to normally work with static/class members and not instances? https://gerrit.osmocom.org/c/pysim/+/37499/comment/3e8ea6c0_b58e2ed3 PS3, Line 23: _num_bits Thanks. Hoewever, I'm not sure I want to introduce python version checks... it's not performance critical. https://gerrit.osmocom.org/c/pysim/+/37499/comment/3165eed2_4a32cdfe PS3, Line 35: from_int decided against enum https://gerrit.osmocom.org/c/pysim/+/37499/comment/f6396316_770c3a44 PS3, Line 35: str Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93 Gerrit-Change-Number: 37499 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jul 2024 16:04:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment