Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37499?usp=email )

Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+ ......................................................................

Patch Set 4:

(4 comments)

File pySim/esim/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/37499/comment/f286c822_7f0588ae PS3, Line 7: pmo4operation

Looks like you want this to be an `enum.IntEnum`? […]

I just played a bit with the idea, but decided against it. First of all, I want lowercase string names as we use lowercase strings everywhere in our json (and all enum.Enum seems to use uppercase). Second, I'm not entirely sure how I can implement the bitstring-compatibility to it, as enum.Enum and derived classes seems to normally work with static/class members and not instances?

https://gerrit.osmocom.org/c/pysim/+/37499/comment/3e8ea6c0_b58e2ed3 PS3, Line 23: _num_bits

FYI, this can be implemented as: […]

Thanks. Hoewever, I'm not sure I want to introduce python version checks... it's not performance critical.

https://gerrit.osmocom.org/c/pysim/+/37499/comment/3165eed2_4a32cdfe PS3, Line 35: from_int

If this class was an `enum.IntEnum`, this API would look like: […]

decided against enum

https://gerrit.osmocom.org/c/pysim/+/37499/comment/f6396316_770c3a44 PS3, Line 35: str

`str` is not a valid type hint for this function, should be `-> 'PMO'` I think

Done