Attention is currently required from: dexter, fixeria.

View Change

4 comments:

• File pySim/esim/__init__.py:

  • Patch Set #3, Line 7: pmo4operation

    Looks like you want this to be an `enum.IntEnum`? […]

    I just played a bit with the idea, but decided against it. First of all, I want lowercase string names as we use lowercase strings everywhere in our json (and all enum.Enum seems to use uppercase). Second, I'm not entirely sure how I can implement the bitstring-compatibility to it, as enum.Enum and derived classes seems to normally work with static/class members and not instances?

  • Patch Set #3, Line 23: _num_bits

    FYI, this can be implemented as: […]

    Thanks. Hoewever, I'm not sure I want to introduce python version checks... it's not performance critical.

  • Patch Set #3, Line 35: from_int

    If this class was an `enum.IntEnum`, this API would look like: […]

    decided against enum

  • Patch Set #3, Line 35: str

    `str` is not a valid type hint for this function, should be `-> 'PMO'` I think

    Done

To view, visit change 37499. To unsubscribe, or for help writing mail filters, visit settings.