Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31354 ) Change subject: layer23: Fix cmdline args not applied ...................................................................... Patch Set 2: Code-Review-1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31354/comment/9e6ae9b0_434f4b19 PS2, Line 10: chicken-and-egg problem It's weird that we ended up having this problem. The usual approach would be: * parse command line options and store params to struct app_data, * allocate one MS with params from struct app_data, * parse the given VTY config file, * apply parameters from the config file, * allocate additional MS if needed, I am not saying this approach is perfect, but the fact that MS already exists when parsing command line options somehow feels wrong. Moreover, applying identical values to all MS is meaningless in most cases (see comments). File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31354/comment/6809aea9_471ff526 PS2, Line 160: llist_for_each_entry At the moment only one MS can be using the L1 PHY (accessed via the layer2_socket_path), so it makes a little sense to assign all MS the same socket path. Additional MS instances may only be allocated via the VTY, where you have per-MS socket path. https://gerrit.osmocom.org/c/osmocom-bb/+/31354/comment/9d2c5f95_ae35eb8e PS2, Line 165: llist_for_each_entry Same here. A single SAP socket cannot be used by several MS simultaneously. We have per-MS SAP socket path in the VTY. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I285a4908401659b69dac513dd1a4b07facb88c51 Gerrit-Change-Number: 31354 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Feb 2023 14:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment