Attention is currently required from: pespin.

Patch set 2:Code-Review -1

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 10: chicken-and-egg problem

    It's weird that we ended up having this problem. The usual approach would be:

    • parse command line options and store params to struct app_data,
    • allocate one MS with params from struct app_data,
    • parse the given VTY config file,
    • apply parameters from the config file,
    • allocate additional MS if needed,

    I am not saying this approach is perfect, but the fact that MS already exists when parsing command line options somehow feels wrong. Moreover, applying identical values to all MS is meaningless in most cases (see comments).

• File src/host/layer23/src/common/main.c:

  • Patch Set #2, Line 160: llist_for_each_entry

    At the moment only one MS can be using the L1 PHY (accessed via the layer2_socket_path), so it makes a little sense to assign all MS the same socket path. Additional MS instances may only be allocated via the VTY, where you have per-MS socket path.

  • Patch Set #2, Line 165: llist_for_each_entry

    Same here. A single SAP socket cannot be used by several MS simultaneously.
    We have per-MS SAP socket path in the VTY.

To view, visit change 31354. To unsubscribe, or for help writing mail filters, visit settings.