Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared ......................................................................
Patch Set 15:
(1 comment)
File src/libmsc/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/03cac104_84808772 PS7, Line 895: esme->esme->own_seq_nr = rand();
ESME stands for External Short Message Entities so it's tied to the SMPP connection. […]
If there's only a user of the struct emse struct then I'm not sure I'm following the need to move it into an own library. If you are moving it to a libray for whatever reason, I'd expect to move/enclose as much implementation in there, not do it only half way.
-
pespin