Attention is currently required from: msuraev.

View Change

1 comment:

• File src/libmsc/smpp_smsc.c:

  • Patch Set #7, Line 895: esme->esme->own_seq_nr = rand();

    ESME stands for External Short Message Entities so it's tied to the SMPP connection. […]

    If there's only a user of the struct emse struct then I'm not sure I'm following the need to move it into an own library.
    If you are moving it to a libray for whatever reason, I'd expect to move/enclose as much implementation in there, not do it only half way.

To view, visit change 28846. To unsubscribe, or for help writing mail filters, visit settings.