[S] Change in osmo-hnbgw[master]: cnpool: add context_map_cnlink_lost() handling - gerrit-log

8 Jun 2023


      Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173 )
Change subject: cnpool: add context_map_cnlink_lost() handling
......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/hnbgw/context_map.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173/comment/1aa5ef49_b58d4380 
PS3, Line 70: 	MAP_SCCP_EV_CN_LINK_LOST,
...
Scenario: […]
IMHO LINK_LOST seems to indicate that lower layer connection (eg. SCTP) or even lower layer link (eg. ethernet) was lost.
If you want to have a single event for all those, which goes from SCTP lost to RANAP RESET because they are to be acted the same way, then fine, but don't only mention "The CN link has a RESET" case.
Otherwise, if you plan to have those as separate event, I'd rather call this EV_RX_RANAP_RESET or alike.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33173
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic0a6fcfb747dc093528ca2bd12a269ad390d465c
Gerrit-Change-Number: 33173
Gerrit-PatchSet: 5
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Thu, 08 Jun 2023 09:16:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment