Attention is currently required from: neels, laforge, pespin.

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 )

Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ......................................................................

Patch Set 6:

(4 comments)

File include/osmocom/hnbgw/context_map.h:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/d59c5475_0f4f47b8 PS6, Line 18: * - For events that may send a RANAP message towards CN via SCCP, the msgb shall have reserved headrom to fit a struct typo: headroom

File src/osmo-hnbgw/context_map_rua.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/269d7c4d_635e9c97 PS6, Line 57: * Assumes local variable fi exists. */ That's very confusing - better make no assumptions and pass all variables explicitly. Hidden parameters are evil.

File src/osmo-hnbgw/context_map_sccp.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/742e3c9a_44de5f9a PS6, Line 63: * Assumes local variable fi exists. */ Same here.

File src/osmo-hnbgw/hnbgw.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/b1652db2_0ca1c82a PS6, Line 862: ranap_msg = msgb_alloc_c(OTC_SELECT, sizeof(struct osmo_scu_prim) + 1500, name); Where does 1500 comes from?