Attention is currently required from: neels, laforge, pespin.

View Change

4 comments:

• File include/osmocom/hnbgw/context_map.h:

  • Patch Set #6, Line 18: * - For events that may send a RANAP message towards CN via SCCP, the msgb shall have reserved headrom to fit a struct

    typo: headroom

• File src/osmo-hnbgw/context_map_rua.c:

  • Patch Set #6, Line 57: * Assumes local variable fi exists. */

    That's very confusing - better make no assumptions and pass all variables explicitly. Hidden parameters are evil.

• File src/osmo-hnbgw/context_map_sccp.c:

  • Patch Set #6, Line 63: * Assumes local variable fi exists. */

    Same here.

• File src/osmo-hnbgw/hnbgw.c:

  • Patch Set #6, Line 862: ranap_msg = msgb_alloc_c(OTC_SELECT, sizeof(struct osmo_scu_prim) + 1500, name);

    Where does 1500 comes from?

To view, visit change 31431. To unsubscribe, or for help writing mail filters, visit settings.