Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/28686
)
Change subject: add VTY option gtp/mockup, for VTY tests
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File src/osmo-upf/osmo_upf_main.c:
https://gerrit.osmocom.org/c/osmo-upf/+/28686/comment/fa74d361_fee07b16
PS1, Line 336: if (upf_gtp_genl_open())
Cannot you keep everything in here in main and simply
avoid calling the functions here?
no. the actions also need to be disabled during
operation.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/28686
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I3b9c796186307fd8562abcff3f0ccfab0e88b6c8
Gerrit-Change-Number: 28686
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Jul 2022 15:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment