Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29376 )
Change subject: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/29376/comment/a1d49dd5_d297b071 PS1, Line 7: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration
i fail to understand this sentence
ipaccess-config uses some shared code with osmo-bsc but doesn't really use some of the fields in there, because it's basically not really acting as a full bsc. Hence, those values are really unset and checking against them make no sense. For instance, arfcn of the BTS.
Patchset:
PS1:
so, by setting 'weak' in libbsc, ipaccess-config can override? […]
Yes, by setting weak ipaccess-config overrides it. As mentioned in an earlier patch, the main problem here is ipaccess-config implementing some lowest layer ipa parts on its own (faking stuff) then pluggin in some shared middle-layer shared code. But rewriting this is totally out of the scope of this patchset.