Attention is currently required from: pespin.

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email )

Change subject: Add multiple messages buffers to io_uring read operations ......................................................................

Patch Set 4:

(7 comments)

File src/core/osmo_io_uring.c:

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/eec89d61_920dc25e?u... : PS3, Line 176: /* Set IO vectors and allocate additional read buffers (but only for READ). */

why only for READ? please explain in the comment.

Done

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/ff3b72d6_fb9f0d88?u... : PS3, Line 179: if (idx)

why we don't do it for idx=0?

Because it is already allocated above at: iofd_msgb_alloc(iodfd); and then added to the msghdr during iofd_msghdr_alloc().

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/20be0165_77a55362?u... : PS3, Line 185:

Can we please clena all the above up by moving the different logic to each of the cases in the switc […]

the cases below have all "/* fall-through */". I still need to check if action == IOFD_ACT_READ.

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/d288394c_5412a827?u... : PS3, Line 236: int chunk;

msghdr->msg[idx] = NULL;

Done

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/9903116d_cb9c804a?u... : PS3, Line 238: if (rc >= 0) {

if you keep the chunk being negative you can remove the extra logic in 246 which imho makes it clear […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/f9324857_82ac71a3?u... : PS3, Line 251: idx++;

moving this idx++ after the for loop may also make it simpler.

Done

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/dc3dcaa0_6f1bb75d?u... : PS3, Line 256: msgb_free(msghdr->msg[idx]);

msghdr->msg[idx] = NULL;

Done