Attention is currently required from: pespin.

View Change

7 comments:

• File src/core/osmo_io_uring.c:

  • Patch Set #3, Line 176: /* Set IO vectors and allocate additional read buffers (but only for READ). */

    why only for READ? please explain in the comment.

    Done

  • Patch Set #3, Line 179: if (idx)

    why we don't do it for idx=0?

    Because it is already allocated above at: iofd_msgb_alloc(iodfd); and then added to the msghdr during iofd_msghdr_alloc().

  • Patch Set #3, Line 185:

    Can we please clena all the above up by moving the different logic to each of the cases in the switc […]

    the cases below have all "/* fall-through */". I still need to check if action == IOFD_ACT_READ.

  • Patch Set #3, Line 236: int chunk;

    msghdr->msg[idx] = NULL;

    Done

  • Patch Set #3, Line 238: if (rc >= 0) {

    if you keep the chunk being negative you can remove the extra logic in 246 which imho makes it clear […]

    Done

  • Patch Set #3, Line 251: idx++;

    moving this idx++ after the for loop may also make it simpler.

    Done

  • Patch Set #3, Line 256: msgb_free(msghdr->msg[idx]);

    msghdr->msg[idx] = NULL;

    Done

To view, visit change 40492. To unsubscribe, or for help writing mail filters, visit settings.