laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29564 )

Change subject: ggsn: Fix TC_gy_charging_volume_quota_threshold expectations ......................................................................

ggsn: Fix TC_gy_charging_volume_quota_threshold expectations

in Diameter, the CC-Input/Output direction is defined as follows in RFC4006: """ 8.24. CC-Input-Octets AVP

The CC-Input-Octets AVP (AVP Code 412) is of type Unsigned64 and contains the number of requested, granted, or used octets that can be/have been received from the end user.

8.25. CC-Output-Octets AVP

The CC-Output-Octets AVP (AVP Code 414) is of type Unsigned64 and contains the number of requested, granted, or used octets that can be/have been sent to the end user. """

So: * 3GPP uplink is from end user to PGW, and hence 'CC-Input-Octets' * 3GPP downlink is to end user to PGW, and hence 'CC-Output-Octets'

This test started failing a few days ago since a bug was recently fixed in open5gs which was swapping the counters in open5gs-upfd: https://github.com/open5gs/open5gs/pull/1793 https://github.com/open5gs/open5gs/commit/f72a1edc6ed35cf5289243d660a73beb0a...

Change-Id: I2f64649ce70d85634f14b84eff98731f7711cbad --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved

diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 0a3bad0..21fdec7 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -2465,11 +2465,11 @@ "TImeout waiting for Gy UPDATE triggered by Volume-Quota-Threshold"); } } - f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..6), 0, (1200..1400)); + f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..6), (1200..1400), 0);

/* ICMP Resp (echo back) generates one report: */ as_DIA_Gy_CCR(ctx, UPDATE_REQUEST); - f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..1), (1200..1400), 0); + f_validate_gy_cc_report(g_rx_gy, THRESHOLD, (0..1), 0, (1200..1400));

/* Second update: 0 ul/dl pkt/octet should be reported, since nothing was sent */ as_DIA_Gy_CCR(ctx, UPDATE_REQUEST);