Attention is currently required from: pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email ) Change subject: vlr: Add support for CS and PS timers ...................................................................... Patch Set 3: (15 comments) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/5c65e163_4951742f?usp… : PS3, Line 46: [VLR_SUB_AS_WAIT_RESP] = { .T = 3260 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/4d5a04b7_8202b34f?usp… : PS3, Line 47: [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3260 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/287ab4e2_35a2e8a2?usp… : PS3, Line 48: [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/ed15b1e5_0460f145?usp… : PS3, Line 52: [VLR_SUB_AS_WAIT_RESP] = { .T = 3360 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/ccd151fa_c2d9db03?usp… : PS3, Line 53: [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3360 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/4aa163f6_0e9678fd?usp… : PS3, Line 54: [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3370 }, please, no spaces at the start of a line File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/0142f72d_57de3e84?usp… : PS3, Line 339: [LU_COMPL_VLR_S_WAIT_IMEI] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/a860e2c4_f9a60e2f?usp… : PS3, Line 340: [LU_COMPL_VLR_S_WAIT_IMEI_TMSI] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/89a24866_67baafe1?usp… : PS3, Line 341: [LU_COMPL_VLR_S_WAIT_TMSI_CNF] = { .T = 3350 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/39592802_698882eb?usp… : PS3, Line 683: [VLR_ULA_S_WAIT_IMEISV] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/cde1fdfd_372109ef?usp… : PS3, Line 684: [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/14ee57bb_68440f49?usp… : PS3, Line 685: [VLR_ULA_S_WAIT_IMSI] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/0d6eceb7_2cf13e74?usp… : PS3, Line 689: [VLR_ULA_S_WAIT_IMEISV] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/20ac0886_4e8243ee?usp… : PS3, Line 690: [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20185): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/362f5b96_802bd868?usp… : PS3, Line 691: [VLR_ULA_S_WAIT_IMSI] = { .T = 3370 }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba Gerrit-Change-Number: 38486 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:02:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No