Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31031 )

Change subject: Add more L1 signals to common part ......................................................................

Patch Set 1:

(2 comments)

File include/osmocom/abis/e1_input.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/31031/comment/1579fa08_8ba36a55 PS1, Line 245: S_L_INP_LINE_LOS, : S_L_INP_LINE_NOLOS, : S_L_INP_LINE_AIS, : S_L_INP_LINE_NOAIS, : S_L_INP_LINE_RAI, : S_L_INP_LINE_NORAI, : S_L_INP_LINE_SLIP_RX, : S_L_INP_LINE_SLIP_TX,

I understand the above signals, but what does the SA_BITS signal do? when is it supposed to be gener […]

I will add a description of the location of the bits.

https://gerrit.osmocom.org/c/libosmo-abis/+/31031/comment/fb4ec6db_5805a40f PS1, Line 370: uint8_t sa_bits;

IIUC this doesn't break ABI in struct size sense, since it's filling a hole.

Yes, it checked it.