Attention is currently required from: daniel, dexter, fixeria.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34445?usp=email )
Change subject: ipa: Don't break strict aliasing rule ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/34445/comment/52a6fb4d_77f3a3b5 PS1, Line 21: osmo_ipa_msgb_cb
You cannot remove public API (which is part of the latest v1.4.0 release).
Ah, alright. So I suppose I can't change any identifiers exposed in headers, unless they have been added after the newest release (?)
I have readded the struct and the removed macro, but added a #warning (I think we should keep some sort of warning, because gcc doesn't always warn about breakage of the strict aliasing rule for whatever reason... that behavior seems to be very version-dependent)