[M] Change in osmo-msc[master]: silent-call: add CSD channel modes - gerrit-log

28 Sep 2024


      Attention is currently required from: falconia.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38311?usp=email )
Change subject: silent-call: add CSD channel modes
......................................................................
Patch Set 1:
(1 comment)
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38311/comment/48aa23b0_9fab28a1?usp=... :
PS1, Line 1596: 		ct.ch_rate_type = sign ? GSM0808_SPEECH_FULL_PREF : GSM0808_SIGN_ANY;
...
It looks like you forgot to reverse the order of `GSM0808_SPEECH_FULL_PREF` and `GSM0808_SIGN_ANY` w […]
Indeed, good catch. Thanks! Fixed.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38311?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ife83f5bcb2b68a228a014f47c7cbb21660290593
Gerrit-Change-Number: 38311
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia falcon@freecalypso.org
Gerrit-Attention: falconia falcon@freecalypso.org
Gerrit-Comment-Date: Sat, 28 Sep 2024 19:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia falcon@freecalypso.org