Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 )
Change subject: layer23: Add inital VTY support for l23_apps ......................................................................
Patch Set 3:
(3 comments)
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/0a16b4ec_7aace038 PS1, Line 103: file.");
missing \n
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/e36d4aac_f87a56a4 PS1, Line 274: OSMO_ASSERT(app->vty_info);
cosmetic: setting up VTY stuff could be done in a separate [static] function, so that it's easier to […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/64259e17_f7d303c9 PS1, Line 331: talloc_free(config_file
Ack
Now I see you're doing talloc_strdup(). But why? I haven't seen this in any other projects. The optarg points to &argv[n], which is supposed to remain available during the program execution time. I see no need to use strdup.
-
fixeria