Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 ) Change subject: layer23: Add inital VTY support for l23_apps ...................................................................... Patch Set 3: (3 comments) File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/0a16b4ec_7aace038 PS1, Line 103: file."); Done https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/e36d4aac_f87a56a4 PS1, Line 274: OSMO_ASSERT(app->vty_info); Done https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/64259e17_f7d303c9 PS1, Line 331: talloc_free(config_file Now I see you're doing talloc_strdup(). But why? I haven't seen this in any other projects. The optarg points to &argv[n], which is supposed to remain available during the program execution time. I see no need to use strdup. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a Gerrit-Change-Number: 30950 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Jan 2023 06:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment