Attention is currently required from: pespin.

View Change

3 comments:

• File src/host/layer23/src/common/main.c:

  • Patch Set #1, Line 103: file.");

    missing \n

    Done

  • Patch Set #1, Line 274: OSMO_ASSERT(app->vty_info);

    cosmetic: setting up VTY stuff could be done in a separate [static] function, so that it's easier to […]

    Done

  • Patch Set #1, Line 331: talloc_free(config_file

    Ack

    Now I see you're doing talloc_strdup(). But why? I haven't seen this in any other projects. The optarg points to &argv[n], which is supposed to remain available during the program execution time. I see no need to use strdup.

To view, visit change 30950. To unsubscribe, or for help writing mail filters, visit settings.