Attention is currently required from: dexter, pespin.

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email )

Change subject: pcuif_proto: signal BTS model via PCUIF ......................................................................

Patch Set 5:

(3 comments)

File src/common/pcu_sock.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899): https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/f1fd686e_a00a520b PS5, Line 235: static enum gsm_pcuif_bts_model bts_model_from_variant(enum gsm_bts_type_variant variant) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899): https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/1d157c99_3a657f80 PS5, Line 246: - case BTS_OSMO_VIRTUAL: space prohibited after that '-' (ctx:ExW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899): https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/1f563543_5d2f1507 PS5, Line 247: return PCU_IF_BTS_MODEL_TRX; code indent should use tabs where possible