Attention is currently required from: dexter, pespin.

View Change

3 comments:

• File src/common/pcu_sock.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899):

    Patch Set #5, Line 235: static enum gsm_pcuif_bts_model bts_model_from_variant(enum gsm_bts_type_variant variant) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899):

    Patch Set #5, Line 246: - case BTS_OSMO_VIRTUAL:

    space prohibited after that '-' (ctx:ExW)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899):

    Patch Set #5, Line 247: return PCU_IF_BTS_MODEL_TRX;

    code indent should use tabs where possible

To view, visit change 34648. To unsubscribe, or for help writing mail filters, visit settings.