Attention is currently required from: neels, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/30116 )
Change subject: [codecs filter] add codec_filter.h,c
......................................................................
Patch Set 1:
(2 comments)
File src/libmsc/codec_filter.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/d98c65fa_ee81bf79
PS1, Line 8: * SPDX-License-Identifier: GPL-2.0+
no AGPL?
Ack
https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/f14d710f_d1c70f9b
PS1, Line 28: static void sdp_add_all_mobile_codecs(struct sdp_audio_codecs *ac)
why is this called "mobile_codecs" but the
one below is "utran_codecs"? Call this oen geran_codecs?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/30116
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4d90f7ca62f2307a7b93dd164aeecbf4bd98ff0a
Gerrit-Change-Number: 30116
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Nov 2022 19:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment