Attention is currently required from: neels, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31033 )

Change subject: Add L1 signals to misdn driver ......................................................................

Patch Set 7:

(5 comments)

File src/input/misdn.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/8385f9a7_7c5e4c9e PS3, Line 115: LOGP(DLMI, LOGL_DEBUG, "L1_SIGNAL_LOS_OFF\n");

I will put the signals into a value_string array. […]

Done

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/59b49fb4_6f3c6e0b PS3, Line 274: mph_information_ind(line, *((int *)msg->data));

This field is machine's endian. There is no conversion in the kernel driver.

Done

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/b10e7f37_14b400b9 PS3, Line 636: mph_information_ind(line, *((int *)msg->data));

I think you forgot to change this one to uint32_t

Done

File src/input/misdn.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/5cea295f_514abb9b PS4, Line 111: isd.sa_bits & 1, (isd.sa_bits >> 1) & 1, (isd.sa_bits >> 2) & 1, (isd.sa_bits >> 3) & 1,

usually indentation goes at the same column after function's "(" char. […]

Done

File src/input/misdn.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/3dbe3013_f66e3840 PS5, Line 110: get_value_string(e1inp_signal_names, S_L_INP_LINE_SA_BITS),

btw, i usually indent to the opening brace because that's what vim does for me, but also simply inde […]

Done