Attention is currently required from: neels, laforge, pespin.

View Change

5 comments:

• File src/input/misdn.c:

  • Patch Set #3, Line 115: LOGP(DLMI, LOGL_DEBUG, "L1_SIGNAL_LOS_OFF\n");

    I will put the signals into a value_string array. […]

    Done

  • Patch Set #3, Line 274: mph_information_ind(line, *((int *)msg->data));

    This field is machine's endian. There is no conversion in the kernel driver.

    Done

  • Patch Set #3, Line 636: mph_information_ind(line, *((int *)msg->data));

    I think you forgot to change this one to uint32_t

    Done

• File src/input/misdn.c:

  • Patch Set #4, Line 111: isd.sa_bits & 1, (isd.sa_bits >> 1) & 1, (isd.sa_bits >> 2) & 1, (isd.sa_bits >> 3) & 1,

    usually indentation goes at the same column after function's "(" char. […]

    Done

• File src/input/misdn.c:

  • Patch Set #5, Line 110: get_value_string(e1inp_signal_names, S_L_INP_LINE_SA_BITS),

    btw, i usually indent to the opening brace because that's what vim does for me, but also simply inde […]

    Done

To view, visit change 31033. To unsubscribe, or for help writing mail filters, visit settings.