Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 ) Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Patch Set 1: (4 comments) File src/host/layer23/src/mobile/gapk_io.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1340): https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/e33ef660_f94ae6ad PS1, Line 20: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1340): https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/46b874ae_b9153581 PS1, Line 21: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File src/host/layer23/src/mobile/vty_interface.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1340): https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/4521ecf1_92ee8982 PS1, Line 2866: strncpy(set->audio.alsa_output_dev, dev_name, Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1340): https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/c4cb3595_80e1690a PS1, Line 2883: strncpy(set->audio.alsa_input_dev, dev_name, Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 23:44:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment