Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string - gerrit-log

1 Feb 2023


      Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 )
Change subject: rlcmac: Refactor msg_type enums and value_string
......................................................................
Patch Set 4:
(1 comment)
File include/osmocom/gprs/rlcmac/types.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/87f5ced8_63235f96 
PS2, Line 53: OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK
...
The new prefix makes these symbols huge and cumbersome to use: […]
we could shorten PACKET to PKT but not sure if it's really worth it. Other than that, I think the prefixes need to be kept, specially since they are public.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447
Gerrit-Change-Number: 31152
Gerrit-PatchSet: 4
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 01 Feb 2023 17:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment