Attention is currently required from: pespin, fixeria, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29761 )
Change subject: msgb: introduce extended copy functions
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/core/msgb.h:
https://gerrit.osmocom.org/c/libosmocore/+/29761/comment/616862f8_ba3a811c
PS3, Line 73: extern struct msgb *msgb_copy_ext(const struct msgb *msg, uint16_t new_len,
const char *name);
what about msgb_copy_resize()? looks more descriptive.
agreeing with pespin.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29761
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36d4c16241d19f0f73c325be4d0e0bdef6813615
Gerrit-Change-Number: 29761
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Oct 2022 12:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment