Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email ) Change subject: stp: add testcases for M3UA-over-TCP ...................................................................... Patch Set 4: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150/comment/7faab9b4_f5be… PS4, Line 1229: f_sleep(1.0); Looking at the code, I see `osmo_stream_cli_set_nodelay(asp->client, true)` being called for both client and server ASP transport roles, regardless of the transport protocol (SCTP or TCP), so it should disabled for osmo-stp. But we do not seem to be disabling it in the testsuite: ``` $ git -C osmo-ttcn3-hacks/ grep -i NODELAY cbc/CBC_Tests.default:*.TCP.noDelay := "yes" // turn off nagle pcap-client/OPCAP_CLIENT_Tests.default:*.TCP.noDelay := "yes" // turn off nagle ``` And this matches what I am observing: the delay is present when the testsuite is sending data to osmo-stp, not vice versa. Even if we disable it in the testsuite, there is still a possibility of one message arriving earlier than the other because those are different sockets. As I said, it's not my own invention and I just copied `f_sleep(1.0)` from the existing code here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e2a887aa22f317783b3207494fd707d7b426439 Gerrit-Change-Number: 36150 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 11:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment