Attention is currently required from: laforge, pespin.

View Change

1 comment:

• File stp/STP_Tests_M3UA.ttcn:

  • Patch Set #4, Line 1229: f_sleep(1.0);

    Nagle should IMHO "obviously" be disabled for M3UA over TCP

    Looking at the code, I see `osmo_stream_cli_set_nodelay(asp->client, true)` being called for both client and server ASP transport roles, regardless of the transport protocol (SCTP or TCP), so it should disabled for osmo-stp.

    But we do not seem to be disabling it in the testsuite:

    ```
    $ git -C osmo-ttcn3-hacks/ grep -i NODELAY
    cbc/CBC_Tests.default:*.TCP.noDelay := "yes" // turn off nagle
    pcap-client/OPCAP_CLIENT_Tests.default:*.TCP.noDelay := "yes" // turn off nagle
    ```

    And this matches what I am observing: the delay is present when the testsuite is sending data to osmo-stp, not vice versa.

    Even if we disable it in the testsuite, there is still a possibility of one message arriving earlier than the other because those are different sockets. As I said, it's not my own invention and I just copied `f_sleep(1.0)` from the existing code here.

To view, visit change 36150. To unsubscribe, or for help writing mail filters, visit settings.