fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28195 )
Change subject: fix gsm_lchan_and_pchan2chan_nr(): log proper lchan_nr value
......................................................................
fix gsm_lchan_and_pchan2chan_nr(): log proper lchan_nr value
VAMOS lchans are behind the primary ones in the ts->lchan[] array.
For example, for TCH/F, there is a primary ts->lchan[0] and a VAMOS
ts->lchan[1]. We should print 'ss 0' for both of them.
Change-Id: I8e7a5a2ecc9b9a33e3ddb76cb1bc04d7802fd320
---
M src/osmo-bsc/gsm_data.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 64c348f..1d6df12 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -600,7 +600,7 @@
if (rc < 0)
LOG_LCHAN(lchan, LOGL_ERROR,
"Error encoding Channel Number: pchan %s ts %u ss %u%s\n",
- gsm_pchan_name(lchan->ts->pchan_from_config), lchan->ts->nr,
lchan->nr,
+ gsm_pchan_name(lchan->ts->pchan_from_config), lchan->ts->nr, lchan_nr,
lchan->vamos.is_secondary ? " (VAMOS shadow)" : "");
return rc;
}
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28195
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8e7a5a2ecc9b9a33e3ddb76cb1bc04d7802fd320
Gerrit-Change-Number: 28195
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged