daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33221 )
Change subject: stream: Update log messages ......................................................................
stream: Update log messages
Change-Id: Ife20b9d18e6ca86a06991d68165694e31052c58a --- M src/stream.c 1 file changed, 16 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/21/33221/1
diff --git a/src/stream.c b/src/stream.c index 782c0fc..c045b83 100644 --- a/src/stream.c +++ b/src/stream.c @@ -437,7 +437,7 @@ if (errno == EPIPE || errno == ENOTCONN) { osmo_stream_cli_reconnect(cli); } - LOGSCLI(cli, LOGL_ERROR, "error %d to send\n", ret); + LOGSCLI(cli, LOGL_ERROR, "received error %d in response to send\n", errno); }
msgb_free(msg); @@ -481,7 +481,7 @@ if (llist_empty(&cli->tx_queue)) osmo_fd_write_disable(&cli->ofd);
- LOGSCLI(cli, LOGL_DEBUG, "connection done.\n"); + LOGSCLI(cli, LOGL_DEBUG, "connection established.\n"); cli->state = STREAM_CLI_STATE_CONNECTED; switch (cli->sk_domain) { case AF_UNIX: @@ -561,7 +561,7 @@ return; }
- LOGSCLI(cli, LOGL_DEBUG, "connection done.\n"); + LOGSCLI(cli, LOGL_DEBUG, "connection established.\n"); cli->state = STREAM_CLI_STATE_CONNECTED; switch (cli->sk_domain) { case AF_UNIX: @@ -599,7 +599,7 @@ return; }
- LOGSCLI(cli, LOGL_DEBUG, "connection done.\n"); + LOGSCLI(cli, LOGL_DEBUG, "connection established.\n"); cli->state = STREAM_CLI_STATE_CONNECTED; switch (cli->sk_domain) { case AF_UNIX: @@ -1565,7 +1565,7 @@ LOGP(DLINP, LOGL_DEBUG, "message received\n");
if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) { - LOGP(DLINP, LOGL_DEBUG, "Connection is being flushed and closed; ignoring received message\n"); + LOGP(DLINP, LOGL_NOTICE, "Connection is being flushed and closed; ignoring received message\n"); return 0; }
@@ -1670,11 +1670,9 @@ OSMO_ASSERT(link->mode == OSMO_STREAM_MODE_OSMO_FD);
conn = talloc_zero(ctx, struct osmo_stream_srv); - if (conn == NULL) { - LOGP(DLINP, LOGL_ERROR, "cannot allocate new peer in srv, " - "reason=`%s'\n", strerror(errno)); + if (conn == NULL) return NULL; - } + conn->srv = link; osmo_fd_setup(&conn->ofd, fd, OSMO_FD_READ, osmo_stream_srv_cb, conn, 0); conn->read_cb = read_cb;
-
daniel