[XS] Change in libosmocore[master]: ns2: trigger a reset in case of receiving a NS STATUS with incompatib... - gerrit-log

11 Dec 2024


      Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email )
Change subject: ns2: trigger a reset in case of receiving a NS STATUS with incompatible protocol state
......................................................................
Patch Set 3:
(1 comment)
File src/gb/gprs_ns2_vc_fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/25559/comment/761128c6_1692fc4b?u... :
PS3, Line 748: 			if (fi->state != GPRS_NS2_ST_RESET && fi->state != GPRS_NS2_ST_UNCONFIGURED) {
shouldn't we also move to some "unconfigured" state ourselves to be in sync with the peer after reset?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I912315f816bd0597d4646627dbfdd270fbae2509
Gerrit-Change-Number: 25559
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 11 Dec 2024 18:50:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No