Attention is currently required from: pespin.

Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )

Change subject: build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac. ......................................................................

Patch Set 1:

(5 comments)

Patchset:

PS1:

You are again mixing different unrelated stuff in the same patch, which is confusing when reviewing […]

Got it. I'll rework this and resend it split into separate orthogonal commits.

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/ecdd1cef_93022584?u... : PS1, Line 12: - Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use

This should be a separate commit, since it's not related at all to the other ones.

Got it. I'll rework this and resend it split into separate orthogonal commits.

File configure.ac:

https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/6f740b5a_8c5b3fab?u... : PS1, Line 242: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes")

Why are you adding ENABLE_TUN? It's never set to "no".

ENABLE_TUN is meant to be the inverse of EMBEDDED, so that tun.c is not built for --enable-embedded. I added it for readability and to make extending the condition easier later (e.g. Emscripten).

File include/osmocom/core/netns.h:

https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/4b1a0aa0_944ca6a8?u... : PS1, Line 5: #if (USE_NETNS)

if netns is not supported, modify Makefile.am to avoid adding this file to the buildset.

Understood. I'll handle this in a separate patch.

File src/core/Makefile.am:

https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/8d202844_7c4aa79a?u... : PS1, Line 83: if ENABLE_TUN

WHy this? AFAICT it can ever be false?

ENABLE_TUN is meant to be the inverse of EMBEDDED, so that tun.c is not built for --enable-embedded. I added it for readability and to make extending the condition easier later (e.g. Emscripten).