Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32575 )
Change subject: trxcon: get rid of the timer driven clock module ......................................................................
Patch Set 3:
(3 comments)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/4c47b592_63016590 PS2, Line 707: .fn = bi.fn,
the trx_fn_advance may still make sense to be possible to apply it here?
I like the idea, thanks! Implemented in the new patchset.
https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/27b22f13_1b5ac0ef PS2, Line 711: trxcon_phyif_handle_rts_ind(trx->priv, &rts);
does that mean that now if we don't receive DL data, we'll never to UL RTS.ind?
Correct.
Is that supposed to work because the BTS is expected to always send data?
Ack.
File src/host/trxcon/src/trxcon_main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/be6edbc7_acd9a0a6 PS2, Line 244: XXX: no-op
Ack
Not needed, this param will remain operational.
-
fixeria