[S] Change in dahdi-linux[master]: drivers/dahdi: fix always true cond - gerrit-log

20 Feb 2025


      Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email )
Change subject: drivers/dahdi: fix always true cond
......................................................................
Patch Set 2:
(1 comment)
File drivers/dahdi/xpp/xbus-core.c:
https://gerrit.osmocom.org/c/dahdi-linux/+/39593/comment/086aca6e_55ce64cf?u... :
PS1, Line 116: 	if (xbus->label) {
...
"*(xbus->label)" in the case of an array is the same as "*(&xbus->label[0]))", which in turs is th […]
And if for whatever reason that's not the case, looks like the origianl intention was precisely that imho, so may be better to do "xbus->label[0] != '\0'"
-- 
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806
Gerrit-Change-Number: 39593
Gerrit-PatchSet: 2
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Thu, 20 Feb 2025 13:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de